Skip to content

[WIP] Update Scala.js#187

Closed
ForNeVeR wants to merge 2 commits intomasterfrom
feature/frontend
Closed

[WIP] Update Scala.js#187
ForNeVeR wants to merge 2 commits intomasterfrom
feature/frontend

Conversation

@ForNeVeR
Copy link
Copy Markdown
Member

Should fix #186. Currently it cannot be built, we're investigating the issue.

@ForNeVeR ForNeVeR mentioned this pull request Aug 20, 2016
@hagane hagane self-assigned this Aug 20, 2016
@hagane
Copy link
Copy Markdown

hagane commented Aug 20, 2016

It's a prime example of jar hell (as opposed to horta hell which is a good thing). Apparently some gorram hipster decided it's pretty smart to use both "io.apigee" % "rhino" % "1.7R5pre4" and "org.mozilla" % "rhino" % "1.7R4". I'll try to deduce the latest version of scalajs plugin lacking this idiocy.

@hagane
Copy link
Copy Markdown

hagane commented Aug 20, 2016

Oh, nevermind, org.mozilla:rhino:1.7R4 is pulled by io.apigee.trireme:trireme-core:0.7.5

@hagane
Copy link
Copy Markdown

hagane commented Aug 20, 2016

And THAT shit is pulled by SBT plugins like "com.typesafe.sbt" % "sbt-less" % "1.0.0" and "com.typesafe.sbt" % "sbt-mocha" % "1.0.0". Oy vey. Their versions probably should be bumped too.

@rexim
Copy link
Copy Markdown
Member

rexim commented May 8, 2017

@ForNeVeR is this still relevant?

@ForNeVeR
Copy link
Copy Markdown
Member Author

ForNeVeR commented May 8, 2017

Yes it is. We still haven' updated the damn' scala.js.

@rexim
Copy link
Copy Markdown
Member

rexim commented Feb 18, 2018

@ForNeVeR I think this PR is dead. Let's close it?

@ForNeVeR
Copy link
Copy Markdown
Member Author

I don't think it's dead. We want to eventually update our Scala.js. Somebody should take it and finish the work. The changes in this PR are useful.

@rexim
Copy link
Copy Markdown
Member

rexim commented Feb 18, 2018

@ForNeVeR if I was assigned to fix #186 right now I'd just start from scratch. Just sayin'. You do you. :)

@ForNeVeR
Copy link
Copy Markdown
Member Author

ForNeVeR commented Feb 18, 2018

@rexim you're right: sometimes I have difficulties differentiating myself from other people. So, if I will be you when I'll be fixing the issue, I'll probably start from scratch. Otherwise I'll likely take other pills actions.

@Minoru
Copy link
Copy Markdown
Member

Minoru commented Oct 15, 2020

Superseded by #225 which updates Scala.js to 1.2.0 (amongst other things).

@Minoru Minoru closed this Oct 15, 2020
@ForNeVeR ForNeVeR deleted the feature/frontend branch October 18, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Scala.js

4 participants