Line endings conversion #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Best change ever! Hope it will make our |
Member
Author
|
It will make contributing and code review easier, because otherwise these changes anyway would pollute our repository inside any random patches (check this as an example). So this change should be made as early as possible. Your irony is inappropriate here. |
Member
|
I'm always serious in PRs. Your remark is inappropriate here. Goat confirms. 🐐 |
Member
Author
|
Now I'm decoupled enough from the state of mind in which I've created this PR. The time has come, I'm starting to review it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #34. We'll use only standard line ending format in future.