Some more minor leaks and one zh translation error#161
Merged
codinguser merged 3 commits intocodinguser:developfrom May 12, 2014
Merged
Some more minor leaks and one zh translation error#161codinguser merged 3 commits intocodinguser:developfrom
codinguser merged 3 commits intocodinguser:developfrom
Conversation
Contributor
Author
|
The commit 5827d61 is a proposed solution to #162 according to the 2nd solution in http://tamsler.blogspot.nl/2011/11/android-viewpager-and-fragments-part-ii.html . The original approach failed as no Fragment is tagged through PagerView. You've already done most of the work for this to work. |
codinguser
added a commit
that referenced
this pull request
May 12, 2014
Fixed: refresh accounts view after exporting and deleting all transactions Fixed: Some more minor leaks and one zh translation error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leaks problems maybe minor this time.
The translation problem is serious, it translated "selected" into "deleted". I was scared when seeing this for the first time, as I was not running on my test account at that time.