Dev check multi#228
Merged
codinguser merged 10 commits intocodinguser:developfrom Sep 24, 2014
Merged
Conversation
Conflicts: app/src/org/gnucash/android/ui/transaction/dialog/SplitEditorDialogFragment.java
codinguser
added a commit
that referenced
this pull request
Sep 24, 2014
Transaction involving multiple currencies cannot be modified. Also add some bug fix to make mutli-currency transactions display correctly. - Rewrite setSplits in Transaction. Now split is not added one by one through addSplit, but the split list is directly assigned. This way the currency information in split is kept. addSplit will reset the currency information. The currency information is used to display the correct currency symbol in split view. - In TransactionFormFragment, when a multi-currency transaction is loaded, every control is disabled except the split edit button. Pressing "save" or changing the account dropdown list on the upper left corner wouldn't change the transaction, an warning is shown instead. Transfer account dropdown is loaded with accounts without the currency restriction, so the correct transfer account can be shown. The split edit button will bring the SplitEditDialogFragment. - In SplitEditDialogFragment, when a multi-currency transaction is loaded, every control in each split is disabled. Pressing the "Add Split" button or "save" button would not change the transaction, a warning is shown instead. Balance in the lower right corner would not be calculated and fixed to zero. The account drop-down for each split is load without the currency restriction, so the correct account can be shown. As currency information for each split is kept (see 1), correct currency symbol is used for each split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one restriction discussed in #220 : Transaction involving multiple currencies cannot be modified.
Also add some bug fix to make mutli-currency transactions display correctly.
setSplitsinTransaction. Now split is not added one by one throughaddSplit, but the split list is directly assigned. This way the currency information in split is kept.addSplitwill reset the currency information. The currency information is used to display the correct currency symbol in split view.TransactionFormFragment, when a multi-currency transaction is loaded, every control is disabled except the split edit button. Pressing "save" or changing the account dropdown list on the upper left corner wouldn't change the transaction, an warning is shown instead. Transfer account dropdown is loaded with accounts without the currency restriction, so the correct transfer account can be shown. The split edit button will bring theSplitEditDialogFragment.SplitEditDialogFragment, when a multi-currency transaction is loaded, every control in each split is disabled. Pressing the "Add Split" button or "save" button would not change the transaction, a warning is shown instead. Balance in the lower right corner would not be calculated and fixed to zero. The account drop-down for each split is load without the currency restriction, so the correct account can be shown. As currency information for each split is kept (see 1), correct currency symbol is used for each split.