delete splits when transaction is saved.#251
Merged
codinguser merged 2 commits intocodinguser:developfrom Oct 15, 2014
Merged
Conversation
Owner
|
Thanks! |
codinguser
added a commit
that referenced
this pull request
Oct 15, 2014
Modify splits only when transaction is saved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the edit of transaction and each split are saved when the transaction is saved (when the save button is clicked in the TransactionFormFragment), except that the splits deleted in the splits view are deleted when the split view exits.
When the splits are saved (resulting in some splits deleted, others edited), but the transaction is not saved, it will result in a transaction with some deleted splits while no other splits change. However, when the transaction is not saved, nothing should change in the transaction, including the deleted splits.
This pull request would make all edits/deletions to splits and edition to transaction to be saved when the save button is clicked in the transactionFormFragment.