Bugfix 641: Weekday is ignored in scheduled exports

[rivaldi8]

Am I late for 2.2?

Please, check I haven't missed any corner case :)

[codinguser]

No, it's not late. I just wanted to get a first beta out as soon as possible so we can get actual user feedback. I'll check it when I get back to my desk. Thanks!

…

On Tue 25. Apr 2017 at 19:40, Àlex Magaz Graça ***@***.***> wrote: Am I late for 2.2? Please, check I haven't missed any corner case :) ------------------------------ You can view, comment on, or merge this pull request online at: #680 Commit Summary - Take into account weekdays on weekly scheduled actions File Changes - *M* app/src/main/java/org/gnucash/android/model/ScheduledAction.java <https://github.com/codinguser/gnucash-android/pull/680/files#diff-0> (40) - *M* app/src/test/java/org/gnucash/android/test/unit/model/ScheduledActionTest.java <https://github.com/codinguser/gnucash-android/pull/680/files#diff-1> (46) Patch Links: - https://github.com/codinguser/gnucash-android/pull/680.patch - https://github.com/codinguser/gnucash-android/pull/680.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#680>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQ4285RNyNAwFWiSb0V4vwSdCTEW9mEks5rzjAagaJpZM4NH0ip> .

[codinguser]

Overall looks good to me, thanks.
Could you please check the failing tests on Travis though?
Do the tests need updating, or does the code break something?

[rivaldi8]

Sorry, I forgot to switch back to the full unit test suite before sending the pull request. It seems the tests have to be updated to set byDays for weekly actions.

Today I have a busy day. I'll fix it tomorrow.

[rivaldi8]

It should be fixed now.

[codinguser]

Cool, thanks. So byday is always set by the recurrence dialog, right?

[rivaldi8]

Yes, the dialog forces you to set at least on weekday. However, after a more thorough inspection, I've found GncXmlHandler never sets the recurrence's byDays. It doesn't parse the weekdays.

Until we don't implement the parsing for imported weekly transaction, I'd add at least one weekday to byDays. We could just use the weekday of the start date. That way it would be executed at least once per week. In fact I'd say that's how it worked until now.

Also, although with a warning, GnuCash desktop allows you to define a weekly transaction without setting any weekday. In that case, it's never executed. So, I'll have to add a check for empty byDays too.

[codinguser]

@rivaldi8 sounds like a plan 👍