Allow denominators up to 1000000 in QIF export#775
Merged
codinguser merged 1 commit intocodinguser:developfrom May 2, 2018
Merged
Allow denominators up to 1000000 in QIF export#775codinguser merged 1 commit intocodinguser:developfrom
codinguser merged 1 commit intocodinguser:developfrom
Conversation
gregwalters
changed the title
Owner
|
Thanks @gregwalters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #771
I was able to reproduce this issue using the current Play store version:
04-25 12:54:36.439 7645 8914 E ExportAsyncTask: Error exporting: Failed to generate export with parameters: Export all transactions created since 1970-01-01 00:00:00.000 UTC as QIF to URI (content:/ /com.android.externalstorage.documents/document/primary%3ASync%2F20180425_125428_gnucash_export_finances.gnucash.qif.zip) - split quantity has illegal denominator: 100000004-25 12:54:36.439 7645 8914 W System.err: org.gnucash.android.export.Exporter$ExporterException: Failed to generate export with parameters: Export all transactions created since 1970-01-01 00:00:00 .000 UTC as QIF to URI (content://com.android.externalstorage.documents/document/primary%3ASync%2F20180425_125428_gnucash_export_finances.gnucash.qif.zip) - split quantity has illegal denominator: 100 0000I fixed the
switchstatement mentioned in #771 by adding a couple cases to it for higher precision numbers and installed the dev version to my phone. Using the dev version I'm able to successfully export transactions and import to gnucash 3.0 on mac.I've ran
gradlew testand all tests pass:BUILD SUCCESSFUL in 4m 1s140 actionable tasks: 62 executed, 78 up-to-date