Skip to content

fix: add required triggers for org ruleset workflow#2

Merged
Mehdi-Bl merged 1 commit intomainfrom
chore/required-zizmor-trigger-fix
Feb 7, 2026
Merged

fix: add required triggers for org ruleset workflow#2
Mehdi-Bl merged 1 commit intomainfrom
chore/required-zizmor-trigger-fix

Conversation

@Mehdi-Bl
Copy link
Copy Markdown
Contributor

@Mehdi-Bl Mehdi-Bl commented Feb 7, 2026

Add pull_request and merge_queue triggers so the workflow can be used by org required_workflows rulesets.

Summary by Sourcery

Build:

  • Add pull_request and merge_queue triggers to the required Zizmor GitHub Actions workflow to support org-level required_workflows rulesets.

@Mehdi-Bl Mehdi-Bl merged commit 7a2b6b3 into main Feb 7, 2026
@Mehdi-Bl Mehdi-Bl deleted the chore/required-zizmor-trigger-fix branch February 7, 2026 20:20
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Feb 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures the 'required-zizmor' GitHub Actions workflow to be triggerable by pull_request and merge_queue events so it can be used as an organization required_workflow ruleset.

Sequence diagram for pull_request and merge_queue triggering required-zizmor workflow

sequenceDiagram
  actor Developer
  participant GitHubRepo
  participant GitHubActions
  participant RequiredWorkflow

  Developer->>GitHubRepo: Open pull_request or update PR
  GitHubRepo-->>GitHubActions: Emit pull_request event
  GitHubActions->>RequiredWorkflow: Start run via pull_request trigger

  Developer->>GitHubRepo: Add PR to merge_queue
  GitHubRepo-->>GitHubActions: Emit merge_queue event
  GitHubActions->>RequiredWorkflow: Start run via merge_queue trigger
Loading

File-Level Changes

Change Details Files
Enable the required workflow to run on pull request and merge queue events in addition to workflow_call.
  • Add pull_request event trigger to the workflow on: block
  • Add merge_queue event trigger to the workflow on: block while keeping existing workflow_call trigger
.github/workflows/required-zizmor.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Consider scoping the pull_request trigger to specific event types (e.g. types: [opened, synchronize]) to avoid unnecessary workflow runs on actions like labeling or assigning.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider scoping the `pull_request` trigger to specific event types (e.g. `types: [opened, synchronize]`) to avoid unnecessary workflow runs on actions like labeling or assigning.

## Individual Comments

### Comment 1
<location> `.github/workflows/required-zizmor.yml:5` </location>
<code_context>

 on:
+  pull_request:
+  merge_queue:
   workflow_call:

</code_context>

<issue_to_address>
**issue (bug_risk):** The `merge_queue` trigger name appears incorrect; GitHub uses `merge_group` for merge queue workflows.

Using `merge_queue` here will stop the workflow from ever running when the merge queue processes items. Please change this event key to `merge_group` and update any logic that depends on the event payload shape if needed.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


on:
pull_request:
merge_queue:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The merge_queue trigger name appears incorrect; GitHub uses merge_group for merge queue workflows.

Using merge_queue here will stop the workflow from ever running when the merge queue processes items. Please change this event key to merge_group and update any logic that depends on the event payload shape if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant