Skip to content

[astro-purgecss] Handle custom 404 page#817

Merged
mhdcodes merged 4 commits intocodiume:mainfrom
Jaanilj:handle-custom-404-page
Dec 30, 2024
Merged

[astro-purgecss] Handle custom 404 page#817
mhdcodes merged 4 commits intocodiume:mainfrom
Jaanilj:handle-custom-404-page

Conversation

@Jaanilj
Copy link
Copy Markdown
Contributor

@Jaanilj Jaanilj commented Dec 26, 2024

Description

This PR adds special handling for the 404 custom error page in Astro integration, ensuring proper file path generation based on Astro's documentation standards.

Changes

Testing

  • Tested with 404.astro page in the src/pages/ folder

Checklist

  • Create changeset
  • Code follows project style guidelines
  • Documentation has been updated if necessary
  • All tests pass
  • Commits are properly formatted and descriptive
  • PR targets appropriate branch

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: b6eb919

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-purgecss Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jaanilj Jaanilj marked this pull request as draft December 26, 2024 22:05
@Jaanilj Jaanilj marked this pull request as ready for review December 27, 2024 07:30
@mhdcodes mhdcodes added astro-purgecss Issues related to astro-purgecss package enhancement New feature or request labels Dec 29, 2024
@mhdcodes mhdcodes changed the title feat: add handling for custom 404 page in Astro integration [astro-purgecss] Handle custom 404 pages Dec 29, 2024
@Jaanilj Jaanilj force-pushed the handle-custom-404-page branch from 50bcbff to 893e0fb Compare December 29, 2024 13:00
mhdcodes
mhdcodes previously approved these changes Dec 29, 2024
@mhdcodes mhdcodes changed the title [astro-purgecss] Handle custom 404 pages [astro-purgecss] Handle custom 404 page Dec 29, 2024
@mhdcodes
Copy link
Copy Markdown
Member

@Jaanilj Thanks for taking the time to send this fix. If this is final, I’ll go ahead and merge it.

@Jaanilj Jaanilj requested a review from mhdcodes December 30, 2024 08:38
@mhdcodes mhdcodes merged commit 260f066 into codiume:main Dec 30, 2024
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
@Jaanilj
Copy link
Copy Markdown
Contributor Author

Jaanilj commented Jan 1, 2025

@Jaanilj Thanks for taking the time to send this fix. If this is final, I’ll go ahead and merge it.

Sorry; was AFK during the new years 🎉 Thanks for the great package and fast review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astro-purgecss Issues related to astro-purgecss package enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants