[astro-purgecss] Handle custom 404 page#817
Merged
mhdcodes merged 4 commits intocodiume:mainfrom Dec 30, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: b6eb919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jaanilj
commented
Dec 26, 2024
Jaanilj
commented
Dec 26, 2024
mhdcodes
approved these changes
Dec 28, 2024
mhdcodes
reviewed
Dec 28, 2024
50bcbff to
893e0fb
Compare
mhdcodes
previously approved these changes
Dec 29, 2024
… and correct comment typo in generateFileHash function
…in build output paths, ensuring proper file generation at root level
893e0fb to
cf092f1
Compare
Member
|
@Jaanilj Thanks for taking the time to send this fix. If this is final, I’ll go ahead and merge it. |
mhdcodes
approved these changes
Dec 30, 2024
Merged
Contributor
Author
Sorry; was AFK during the new years 🎉 Thanks for the great package and fast review 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds special handling for the
404custom error page in Astro integration, ensuring proper file path generation based on Astro's documentation standards.Changes
404/pathname to generate404.htmlat the root levelTesting
404.astropage in thesrc/pages/folderChecklist