Conversation
Contributor
amirbilu
commented
Jun 18, 2023
amirbilu
commented
- switch to vim version
- switch to vim version
Contributor
Author
|
@aarondill can you please approve? this is following #79 |
aarondill
reviewed
Jun 18, 2023
| return semver.parse(path) | ||
| end, paths) | ||
|
|
||
| table.sort(paths) |
Contributor
There was a problem hiding this comment.
Does table.sort() work on these objects? have we checked this?
Contributor
There was a problem hiding this comment.
Nevermind, having tested myself, it seems that it does, in fact, work. I wonder if internally it's using the __lt/__gt methods...
Contributor
Author
There was a problem hiding this comment.
Oh yes.. it does :)
aarondill
suggested changes
Jun 18, 2023
aarondill
added a commit
to aarondill/tabnine-nvim
that referenced
this pull request
Jun 19, 2023
This reverts commit ab88220. vim.version is not supported in `nvim <9.0.0`
aarondill
added a commit
to aarondill/tabnine-nvim
that referenced
this pull request
Jun 19, 2023
This reverts commit ab88220. vim.version is not supported in `nvim <0.9.0`
Merged
amirbilu
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Revert "vim version (#80)" This reverts commit ab88220. vim.version is not supported in `nvim <0.9.0` * fix use of vim.version for support with nvim <0.9.0 * use semver with vim.version without additional string processing better uses the semver() function to process vim.version, as we already have it split into major, minor, patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.