deploy animated texts to prod#442
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sanjana Podduturi <59354376+P-Sanjana@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
#441) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying animata with
|
| Latest commit: |
da9d7b2
|
| Status: | ⚡️ Build in progress... |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34b4cadfeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id="main-content" | ||
| className="relative py-6 lg:gap-10 lg:py-8 xl:grid xl:grid-cols-[1fr_150px]" | ||
| > | ||
| <main id="main-content" className="relative py-6 lg:gap-10 lg:py-8 xl:grid"> |
There was a problem hiding this comment.
At the XL breakpoint this page now sets only xl:grid without any grid-cols definition, so docs with a table of contents render the TOC block below the article instead of in the right column. This regresses desktop navigation behavior compared with the blog page (which still uses xl:grid-cols-[1fr_150px]) and makes the sticky TOC much less useful on large screens.
Useful? React with 👍 / 👎.
| const samplesKey = useMemo(() => samples?.join("") ?? "", [samples]); | ||
| const phrasesKey = useMemo(() => phrases?.map((p) => p.join("")).join("") ?? "", [phrases]); |
There was a problem hiding this comment.
These keys can collide for different inputs (for example samples undefined, [], and [""] all produce ""), so the animation effect will not rerun when content changes across those states. Because the effect snapshots liveSamples/livePhrases once at startup, the component can keep animating stale text until some unrelated dependency changes.
Useful? React with 👍 / 👎.
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
No description provided.