Skip to content

Revert k8s resources renaming#137

Merged
sd109 merged 1 commit intomainfrom
sd/revert-resource-rename
Jan 16, 2026
Merged

Revert k8s resources renaming#137
sd109 merged 1 commit intomainfrom
sd/revert-resource-rename

Conversation

@sd109
Copy link
Contributor

@sd109 sd109 commented Jan 16, 2026

This reverts commit 88e1610.

In hindsight, it causes more trouble than it saves...

@gemini-code-assist
Copy link

Summary of Changes

Hello @sd109, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request rolls back a prior commit that had introduced a more granular, but ultimately problematic, naming convention for Kubernetes resources. The primary goal of this revert is to simplify and standardize the naming of ping-pong client and server components across various deployment configurations, such as 'cofide', 'jwt', and 'mesh', by removing the specific suffixes from their Kubernetes manifests. This change streamlines resource identification and management, addressing issues encountered with the previous naming strategy.

Highlights

  • Kubernetes Resource Naming Reversion: The pull request reverts a previous commit that introduced specific naming conventions for Kubernetes resources, removing environment/mode suffixes (e.g., '-cofide', '-jwt', '-mesh') from resource names.
  • Standardized Resource Names: Resource names for ServiceAccounts, Deployments, Services, application labels, service account names, and container names are standardized to 'ping-pong-client' and 'ping-pong-server' across different workload types.
  • Simplification of Configuration: This change aims to simplify Kubernetes configurations by rolling back to a more generic and less verbose naming scheme, as the previous approach 'caused more trouble than it saves'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the renaming of Kubernetes resources across several deployment files. While I understand this is a revert, it re-introduces a significant issue: multiple deployment configurations now define resources with the same names (e.g., ping-pong-client, ping-pong-server). If these different workload variants (cofide, jwt, mesh) are deployed into the same Kubernetes namespace, it will cause resource conflicts, and only one variant can exist at a time. This could lead to unexpected behavior and deployment failures. I've added critical comments to highlight this issue. Additionally, I've pointed out a minor formatting issue with trailing whitespace.

This reverts commit 88e1610.

In hindsight, it causes more trouble than it saves...
@sd109 sd109 force-pushed the sd/revert-resource-rename branch from fb10fc4 to 9c7ef91 Compare January 16, 2026 17:48
@sd109 sd109 enabled auto-merge January 16, 2026 17:50
@sd109 sd109 merged commit 9c8c0b7 into main Jan 16, 2026
2 checks passed
@sd109 sd109 deleted the sd/revert-resource-rename branch January 16, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants