Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 79.94% 80.38% +0.44%
==========================================
Files 43 43
Lines 3904 3890 -14
==========================================
+ Hits 3121 3127 +6
+ Misses 783 763 -20
🚀 New features to boost your workflow:
|
einarmo
reviewed
Aug 7, 2025
Contributor
einarmo
left a comment
There was a problem hiding this comment.
One small comment, but this seems pretty reasonable. Ends up being a nice separation of concerns as well, removing checkin logic from the base extractor.
einarmo
previously approved these changes
Aug 7, 2025
einarmo
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOG-5739
This is an implementation of the
CheckinWorkerin the extractor. It is the final part of this PR.It also includes removal of some tests which were related to the previous implementation.