Skip to content

Integrate checkin worker#466

Merged
toondaey merged 9 commits intomasterfrom
impl-checkin-worker
Aug 12, 2025
Merged

Integrate checkin worker#466
toondaey merged 9 commits intomasterfrom
impl-checkin-worker

Conversation

@toondaey
Copy link
Copy Markdown
Contributor

@toondaey toondaey commented Aug 4, 2025

DOG-5739

This is an implementation of the CheckinWorker in the extractor. It is the final part of this PR.
It also includes removal of some tests which were related to the previous implementation.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.38%. Comparing base (80d0b1e) to head (9d23c5d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/unstable/core/runtime.py 37.50% 5 Missing ⚠️
cognite/extractorutils/unstable/core/base.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   79.94%   80.38%   +0.44%     
==========================================
  Files          43       43              
  Lines        3904     3890      -14     
==========================================
+ Hits         3121     3127       +6     
+ Misses        783      763      -20     
Files with missing lines Coverage Δ
...te/extractorutils/unstable/configuration/models.py 84.97% <100.00%> (+0.08%) ⬆️
...ite/extractorutils/unstable/core/checkin_worker.py 85.55% <100.00%> (+8.02%) ⬆️
cognite/extractorutils/unstable/core/base.py 76.60% <90.90%> (+2.24%) ⬆️
cognite/extractorutils/unstable/core/runtime.py 71.27% <37.50%> (-1.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toondaey toondaey marked this pull request as ready for review August 5, 2025 07:28
@toondaey toondaey requested a review from a team as a code owner August 5, 2025 07:28
Copy link
Copy Markdown
Contributor

@einarmo einarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but this seems pretty reasonable. Ends up being a nice separation of concerns as well, removing checkin logic from the base extractor.

einarmo
einarmo previously approved these changes Aug 7, 2025
@toondaey toondaey added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Aug 7, 2025
Copy link
Copy Markdown
Contributor

@einarmo einarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@einarmo einarmo self-assigned this Aug 8, 2025
@einarmo einarmo added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Aug 8, 2025
@toondaey toondaey merged commit 319934b into master Aug 12, 2025
6 checks passed
@toondaey toondaey deleted the impl-checkin-worker branch August 12, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants