Skip to content

🦟Fix flaky test.#2785

Merged
doctrino merged 1 commit intomainfrom
actual-fix
Mar 25, 2026
Merged

🦟Fix flaky test.#2785
doctrino merged 1 commit intomainfrom
actual-fix

Conversation

@doctrino
Copy link
Copy Markdown
Contributor

Description

See docstring in _standardize.

Bump

  • Patch
  • Skip

@doctrino doctrino requested review from a team as code owners March 25, 2026 13:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino doctrino enabled auto-merge (squash) March 25, 2026 13:38
@doctrino
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new private helper methods, _standardize and _standardize_resource_directories, within the TestReadBuildDirectory class. These methods are designed to sort the output of read_build_directory to ensure deterministic test results, addressing the non-deterministic ordering behavior of glob() which was causing flaky tests. No specific feedback was provided in the review comments.

@github-actions
Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
39255 33304 85% 80% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fb36ff3 by action🐍

@doctrino doctrino merged commit 070194a into main Mar 25, 2026
14 checks passed
@doctrino doctrino deleted the actual-fix branch March 25, 2026 13:43
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (ed0f73e) to head (fb36ff3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2785      +/-   ##
==========================================
- Coverage   84.84%   84.84%   -0.01%     
==========================================
  Files         447      447              
  Lines       39255    39255              
==========================================
- Hits        33305    33304       -1     
- Misses       5950     5951       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants