Fix quality.rules wire format: use externalId not ruleSetExternalId#3003
Conversation
The API spec defines quality.rules items as RuleSetVersionReference
with {externalId, version}, not {ruleSetExternalId, version}.
- Replace list[RuleSetVersionId] with a new RuleSetVersionRef class
whose external_id field serialises as externalId on the wire
- Rename DataProductVersionQualityRule.rule_set_external_id to
external_id so users write `externalId:` in their YAML
- Update get_dependent_items to look up "externalId" in the raw dict
- Update tests to use the correct field name
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 465 465
Lines 42695 42698 +3
=======================================
+ Hits 36685 36688 +3
Misses 6010 6010
🚀 New features to boost your workflow:
|
Summary
quality.rulesitems asRuleSetVersionReferencewith{externalId, version}, not{ruleSetExternalId, version}list[RuleSetVersionId]inDataProductVersionQualitywith a newRuleSetVersionRefclass whoseexternal_idfield serialises asexternalIdon the wireDataProductVersionQualityRule.rule_set_external_id→external_idso the correct user-facing YAML field isexternalId:(notruleSetExternalId:)get_dependent_itemsto key on"externalId"in the raw dictCorrect YAML
Bump
Changelog
Fixed
quality.ruleswire format to useexternalIdinstead ofruleSetExternalIdwhen serialising data product version quality rules.