Skip to content

Remove moderate from SDK#104

Merged
mkozakov merged 4 commits intomainfrom
remove-moderate
Oct 11, 2022
Merged

Remove moderate from SDK#104
mkozakov merged 4 commits intomainfrom
remove-moderate

Conversation

@mkozakov
Copy link
Copy Markdown
Collaborator

@mkozakov mkozakov commented Sep 30, 2022

Remove the experimental Moderate endpoint from the SDK

@mkozakov mkozakov requested review from 1vn and jimwu6 September 30, 2022 00:11
Comment thread CHANGELOG.md

## 2.6.0
* [#104](https://github.com/cohere-ai/cohere-python/pull/96)
* Remove experimental `moderate` api
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a major semver bump, since it is breaking with past versions that use moderate?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh unless we don't consider it breaking because the endpoint was experimental 🤔 -- pls disregard comment if so.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't formalized it, but unofficially we talk about experimental APIs as pre-beta. That means that an experimental api can be pulled at any point without a version change

Copy link
Copy Markdown
Contributor

@eddotman eddotman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might also want to remove this line.

I left a versioning question as well, but the other parts LGTM 🚀

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 11, 2022

CLA assistant check
All committers have signed the CLA.

@mkozakov mkozakov requested a review from eddotman October 11, 2022 21:48
@mkozakov
Copy link
Copy Markdown
Collaborator Author

I think we might also want to remove this line.

I left a versioning question as well, but the other parts LGTM 🚀

Good catch! VSCode didn't save the file when i removed it :(

@mkozakov mkozakov merged commit 44104b8 into main Oct 11, 2022
@mkozakov mkozakov deleted the remove-moderate branch October 11, 2022 21:57
mkozakov added a commit that referenced this pull request Oct 12, 2022
Copy link
Copy Markdown
Member

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@branep branep added the hotfix label Nov 14, 2022
vshmyhlo pushed a commit that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants