Skip to content

Fix sagemaker client #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix sagemaker client #596

merged 2 commits into from
Oct 30, 2024

Conversation

@billytrend-cohere
Copy link
Collaborator

@billytrend-cohere billytrend-cohere commented Oct 30, 2024 •
edited by cohere-pr-pal bot
Loading

This PR updates the client.py file in the cohere_aws package. The changes ensure that the AWS client is correctly configured to use the sagemaker service.

  • The boto3.client() call is now passed the "sagemaker" argument to specify the service.
  • The os.environ['AWS_DEFAULT_REGION'] is set to the aws_region if it is not already set.
  • The sage.Session is created with the sagemaker_client parameter set to the self._service_client.

@billytrend-cohere billytrend-cohere merged commit f31b9a5 into main Oct 30, 2024
3 checks passed
@billytrend-cohere billytrend-cohere deleted the billytrend-cohere-patch-3 branch October 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkozakov mkozakov mkozakov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billytrend-cohere @mkozakov