refactor(aigc): remove character index references, keep only characte…#37
Conversation
…r names - Removed CharacterRefs field from SourceTextSegment struct - Removed character_refs from JSON schema - Updated prompt instructions to use only character_names without indices Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: zhangzqs <34616640+zhangzqs@users.noreply.github.com>
|
Overall: Clean refactoring that simplifies the character reference system. The changes are well-executed with proper documentation updates. However, this PR introduces a breaking change that affects Critical Issue: Positive aspects: Eliminates redundancy, improves maintainability, and makes the API more intuitive with name-based references instead of fragile index lookups. |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| // CharacterRefs 标注对应角色画像在本章角色列表中的索引 | ||
| CharacterRefs []int `json:"character_refs,omitempty"` | ||
| // CharacterNames 冗余记录角色姓名，便于生成端保持一致 | ||
| // CharacterNames 记录角色姓名，便于生成端保持一致 |
There was a problem hiding this comment.
Good simplification - removing "冗余" accurately reflects that CharacterNames is now the primary (not redundant) method for character references.
2 participants
…r names
Generated with codeagent