Portability and warning fixes#601
Conversation
|
@tritao Soft bump, any progress on the issue? |
|
@VolkerEnderlein This one does not have any conflicts, is there anything you want addressed? |
|
@tritao I left a review comment to remove the superfluous line |
|
Weird, I don't see it, but alright, I'll update this and the other PRs ASAP. |
|
When opening the PR without being logged in, I am also unable to see the review comment, maybe thats the issue. Thanks, Cheers |
VolkerEnderlein
left a comment
VolkerEnderlein
left a comment
There was a problem hiding this comment.
It would be nice if you could address this.
|
|
||
| #ifdef HAVE_TIME_H | ||
| #include <ctime> | ||
| #include <time.h> |
There was a problem hiding this comment.
Header <time.h> is a C include. It is included in C++ files as <ctime>. So this line can be safely removed
|
The issue was on my side, I did not properly finished the review session, it was still pending :( Sorry for that. |
tritao
force-pushed
the
pr/modern-gl/004-portability-warnings
branch
from
50144f4 to
f795d85
Compare
|
Updated, can you check this latest version? |
2 participants
Summary
Small portability and warning fixes to keep builds clean and predictable on modern toolchains.
Why
These are small, low-risk changes that reduce build friction (warnings and portability nits) before the larger rendering work lands.
Changes
clock_gettimewhen available (src/base/time.cpp).src/xml/element.cpp.Testing
Not run in isolation.
Commits
8c1d4f52a4: Fix wrong specifier warnings in element.cpp3be632727a: Useclock_gettimewhen its available instead of deprecate…