Skip to content

Fixed a bug where chain_id was being trated as a network_id#382

Merged
CarsonRoscoe merged 6 commits intomainfrom
bug/eth-account-wallet-provider-chain-id
Feb 14, 2025
Merged

Fixed a bug where chain_id was being trated as a network_id#382
CarsonRoscoe merged 6 commits intomainfrom
bug/eth-account-wallet-provider-chain-id

Conversation

@CarsonRoscoe
Copy link
Copy Markdown
Contributor

@CarsonRoscoe CarsonRoscoe commented Feb 13, 2025

What changed?

  • Documentation
  • Bug fix
  • New Action
  • New Action Provider
  • Other
  1. A recent refactoring of EthAccountWalletProvider's config from network_id to chain_id had a missed case in the constructor that was not updated.

  2. EthAccountWalletProvider's chain_id was requesting a string, however the chain_id types defined elseware were int's

Why was this change implemented?

Without this fix, we are unable to instantiate a EthAccountWalletProvider following the example in the README.

Network support

  • All EVM
  • Base
  • Base Sepolia
  • Other

Wallet support

  • CDP Wallet
  • EVM Wallet
  • Other
    EthAccountWalletProvider

Checklist

  • Changelog updated
  • Commits are signed. See instructions
  • Doc strings
  • Readme updates
  • Rebased against master
  • Relevant exports added

How has it been tested?

  • Agent tested
  • Unit tests

Notes to reviewers

@cb-heimdall
Copy link
Copy Markdown

cb-heimdall commented Feb 13, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@CarsonRoscoe CarsonRoscoe merged commit 9c3ce58 into main Feb 14, 2025
10 checks passed
@CarsonRoscoe CarsonRoscoe deleted the bug/eth-account-wallet-provider-chain-id branch February 14, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants