Skip to content

Conversation

@aramxc
Copy link

@aramxc aramxc commented Feb 24, 2025

What changed?

  • Documentation
  • Bug fix
  • New Action
  • New Action Provider
  • Other

Why was this change implemented?

Docs were a bit misleading for initial startup. Renamed key name to API Key ID and private key to secret key to match what is shown in developer portal when creating API keys. PR created during ETH Denver Buidlathon.

Network support

  • All EVM
  • Base
  • Base Sepolia
  • Other

Wallet support

  • CDP Wallet
  • EVM Wallet
  • Other

Checklist

  • Changelog updated
  • Commits are signed. See instructions
  • Doc strings
  • Readme updates
  • Rebased against master
  • Relevant exports added

How has it been tested?

  • Agent tested
  • Unit tests

Notes to reviewers

@aramxc aramxc requested a review from murrlincoln as a code owner February 24, 2025 19:11
@cb-heimdall
Copy link

cb-heimdall commented Feb 24, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation needs triage labels Feb 24, 2025
@0xRAG
Copy link
Contributor

0xRAG commented Mar 3, 2025

Thanks @aramxc! Could you please rebase main, there is a merge conflict in the README.md

@0xRAG 0xRAG added cherry and removed needs triage labels Mar 3, 2025
@0xRAG 0xRAG mentioned this pull request Mar 3, 2025
20 tasks
@0xRAG 0xRAG removed the needs triage label Mar 4, 2025
@aramxc aramxc requested a review from 0xRAG March 6, 2025 22:55
0xRAG
0xRAG previously approved these changes Mar 6, 2025
@0xRAG
Copy link
Contributor

0xRAG commented Mar 6, 2025

@aramxc we require commit signing on all commits, it looks like the first one wasn't signed. Feel free to squash your commits, or remove the first commit.

@github-actions github-actions bot removed example New example agent framework extension New framework extension python typescript labels Mar 7, 2025
@0xRAG 0xRAG removed the needs triage label Mar 7, 2025
@aramxc
Copy link
Author

aramxc commented Mar 7, 2025

@0xRAG Sorry for all the noise. I need to stay on top of checking notifications so PRs in active repos dont go stale which caused me a few headaches... Should be good to go!

@phdargen
Copy link
Contributor

Could be merged @CarsonRoscoe

@CarsonRoscoe
Copy link
Contributor

Looking at the merge conflict on README.md, this was addressed in another PR that got merged in. Thank you though for the contribution, and apologies for not merging this in time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

5 participants