-
Notifications
You must be signed in to change notification settings - Fork 580
Update README.md #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #455
Conversation
✅ Heimdall Review Status
|
|
Thanks @aramxc! Could you please rebase |
|
@aramxc we require commit signing on all commits, it looks like the first one wasn't signed. Feel free to squash your commits, or remove the first commit. |
3091c10 to
928ec17
Compare
|
@0xRAG Sorry for all the noise. I need to stay on top of checking notifications so PRs in active repos dont go stale which caused me a few headaches... Should be good to go! |
|
Could be merged @CarsonRoscoe |
|
Looking at the merge conflict on README.md, this was addressed in another PR that got merged in. Thank you though for the contribution, and apologies for not merging this in time |
What changed?
Why was this change implemented?
Docs were a bit misleading for initial startup. Renamed key name to API Key ID and private key to secret key to match what is shown in developer portal when creating API keys. PR created during ETH Denver Buidlathon.
Network support
Wallet support
Checklist
How has it been tested?
Notes to reviewers