fix: assigning gas estimations and chainId in sendTransaction#714
Merged
CarsonRoscoe merged 1 commit intoMay 14, 2025
Merged
Conversation
✅ Heimdall Review Status
|
github-actions
Bot
added
action provider
sammccord
approved these changes
May 14, 2025
|
Review Error for sammccord @ 2025-05-14 21:56:06 UTC |
0xRAG
approved these changes
May 14, 2025
This was referenced May 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning gas estimations and chain id in sendTransaction to ensure they are EIP1559 transactions.
Tested locally via confirming the issue existed leveraging the wrap eth to weth action, and then ensuring it worked locally after the above changes.
Note: I noticed the
CdpV2ApiActionProviderwas finicky about injecting the wallet provider. This is because my custom type was failing the=== WalletProvidercheck in certain environments (worked with vercel ai agents, but was finicky in langchain). I refactor to a type guard.