Skip to content

feat(PSDK-584): Read contract support#29

Merged
rohan-agarwal-coinbase merged 9 commits intov0.0.6from
rohan/PSDK-584
Oct 17, 2024
Merged

feat(PSDK-584): Read contract support#29
rohan-agarwal-coinbase merged 9 commits intov0.0.6from
rohan/PSDK-584

Conversation

@rohan-agarwal-coinbase
Copy link
Copy Markdown
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Oct 16, 2024

What changed? Why?

  • Added read_contract function to smart_contract.py

Testing

  • Unit tests
  • Tested e2e with my backend service changes

Qualified Impact

@cb-heimdall
Copy link
Copy Markdown

cb-heimdall commented Oct 16, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase marked this pull request as ready for review October 17, 2024 03:48
@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the base branch from master to v0.0.6 October 17, 2024 13:16
@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the title feat(PSDK-584): Read Contract support feat(PSDK-584): Read contract support Oct 17, 2024
@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit cb82eb1 into v0.0.6 Oct 17, 2024
rohan-agarwal-coinbase added a commit that referenced this pull request Oct 17, 2024
* feat(PSDK-584): Read contract support (#29)

* Update to 0.0.6 and update docs and changelog (#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants