Skip to content

fix: clarify contributing requirements#312

Merged
hcopp merged 2 commits intomasterfrom
hunter/contributing-updates
Jan 21, 2026
Merged

fix: clarify contributing requirements#312
hcopp merged 2 commits intomasterfrom
hunter/contributing-updates

Conversation

@hcopp
Copy link
Copy Markdown
Contributor

@hcopp hcopp commented Jan 20, 2026

What changed? Why?

This PR improves our contributing docs based on feedback from contributors.

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@hcopp hcopp self-assigned this Jan 20, 2026
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jan 20, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@hcopp hcopp merged commit f333f51 into master Jan 21, 2026
21 checks passed
@hcopp hcopp deleted the hunter/contributing-updates branch January 21, 2026 16:08
cb-ekuersch pushed a commit that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants