Skip to content

chore: Improve code connect workflow & setup#318

Merged
cb-ekuersch merged 3 commits intomasterfrom
workflow
Jan 21, 2026
Merged

chore: Improve code connect workflow & setup#318
cb-ekuersch merged 3 commits intomasterfrom
workflow

Conversation

@cb-ekuersch
Copy link
Copy Markdown
Contributor

@cb-ekuersch cb-ekuersch commented Jan 21, 2026

  • clear error message when api token is missing in CI
  • skip validation steps when branch is a fork
  • remove mapping files from old Select component which were recently broken
  • skip figma connect files from version bumps

What changed? Why?

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jan 21, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

hcopp
hcopp previously approved these changes Jan 21, 2026
hcopp
hcopp previously approved these changes Jan 21, 2026
@cb-ekuersch cb-ekuersch changed the title chore: add clear error message for missing secret and restrict figma … chore: Improve code connect workflow & setup Jan 21, 2026
@cb-ekuersch cb-ekuersch merged commit de719bb into master Jan 21, 2026
23 checks passed
@cb-ekuersch cb-ekuersch deleted the workflow branch January 21, 2026 22:27
cb-ekuersch added a commit that referenced this pull request Jan 30, 2026
* clear error message when api token is missing in CI
* skip validation steps when branch is a fork
* remove mapping files from old Select component which were recently broken
* skip figma connect files from version bumps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants