Skip to content

fix: make custom beacon chart stable in visreg#331

Merged
hcopp merged 2 commits intomasterfrom
hunter/line-chart-beacon-stable-visreg
Jan 27, 2026
Merged

fix: make custom beacon chart stable in visreg#331
hcopp merged 2 commits intomasterfrom
hunter/line-chart-beacon-stable-visreg

Conversation

@hcopp
Copy link
Contributor

@hcopp hcopp commented Jan 27, 2026

What changed? Why?

This PR makes a line chart example stable so the data is the same each load.

Root cause (required for bugfixes)

This example was generating new random data each time and as a result was being flagged in visual regression tests.

UI changes

Before

Random data each load

After

Static sample data

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@hcopp hcopp requested a review from sverg-cb January 27, 2026 21:22
@hcopp hcopp self-assigned this Jan 27, 2026
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 27, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@hcopp hcopp merged commit 3d4d559 into master Jan 27, 2026
22 checks passed
@hcopp hcopp deleted the hunter/line-chart-beacon-stable-visreg branch January 27, 2026 21:47
cb-ekuersch pushed a commit that referenced this pull request Jan 30, 2026
* fix: make custom beacon chart stable in visreg

* Reuse sample data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants