Skip to content

chore: descriptive names for generic types#341

Merged
adrienzheng-cb merged 2 commits intomasterfrom
adrien/DX-5037
Jan 29, 2026
Merged

chore: descriptive names for generic types#341
adrienzheng-cb merged 2 commits intomasterfrom
adrien/DX-5037

Conversation

@adrienzheng-cb
Copy link
Copy Markdown
Contributor

What changed? Why?

Added descriptive name for all generic types (Tabs family, Tour, Select family) to increase the clarity of our type definition.

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jan 29, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@adrienzheng-cb adrienzheng-cb marked this pull request as ready for review January 29, 2026 18:44
@adrienzheng-cb adrienzheng-cb changed the title chore: descriptive name for generic types chore: descriptive names for generic types Jan 29, 2026
@adrienzheng-cb adrienzheng-cb merged commit 138ffc5 into master Jan 29, 2026
27 of 30 checks passed
@adrienzheng-cb adrienzheng-cb deleted the adrien/DX-5037 branch January 29, 2026 19:11
maximo-macchi-cb pushed a commit that referenced this pull request Jan 29, 2026
* chore: descriptive name for generic types

* update changelog
cb-ekuersch pushed a commit that referenced this pull request Jan 30, 2026
* chore: descriptive name for generic types

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants