Skip to content

fix: bar chart enter animation & min size#540

Merged
hcopp merged 15 commits intomasterfrom
hunter/barchart-improvements
Mar 25, 2026
Merged

fix: bar chart enter animation & min size#540
hcopp merged 15 commits intomasterfrom
hunter/barchart-improvements

Conversation

@hcopp
Copy link
Copy Markdown
Contributor

@hcopp hcopp commented Mar 24, 2026

What changed? Why?

This PR cleans up a lot of issues with BarChart

  1. Better organization - store/reuse from bar.ts as much as possible
  2. Enter animation fixes - we weren't doing stack animations correctly on web for horizontal charts
  3. BarMinSize/StackMinSize - before barMinSize wouldn't work at all; stackMinSize worked but wouldn't impact enter animation; now the min size is used from the start to the end, aligning with motion expectations

UI changes

Slowed down

iOS Old iOS New
BeforeMobile.mov
AfterMobile.mov
Web Old Web New
Before.mov
After.mov

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Mar 24, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 2/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

Comment thread packages/web-visualization/src/chart/bar/DefaultBar.tsx Outdated
Comment thread packages/web-visualization/src/chart/bar/DefaultBarStack.tsx Outdated
Comment thread packages/mobile-visualization/src/chart/bar/Bar.tsx Outdated
Comment thread packages/mobile-visualization/src/chart/utils/bar.ts
Comment thread packages/mobile-visualization/src/chart/utils/bar.ts Outdated
@hcopp hcopp self-assigned this Mar 24, 2026
@hcopp hcopp marked this pull request as ready for review March 24, 2026 21:18
@hcopp hcopp requested a review from sverg-cb March 24, 2026 21:19
@hcopp hcopp merged commit a9a8d02 into master Mar 25, 2026
29 checks passed
@hcopp hcopp deleted the hunter/barchart-improvements branch March 25, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants