Skip to content

fix: [CDS-1798] Remove usage of Array.prototype.at()#575

Merged
maximo-macchi-cb merged 3 commits intomasterfrom
max/remove-array-at-method
Apr 1, 2026
Merged

fix: [CDS-1798] Remove usage of Array.prototype.at()#575
maximo-macchi-cb merged 3 commits intomasterfrom
max/remove-array-at-method

Conversation

@maximo-macchi-cb
Copy link
Copy Markdown
Contributor

What changed? Why?

This PR removes the usage of the Array.prototype.at() method (MDN docs). It's replaced by standard bracket usage for accessing specific indices in an array.

The method is being removed to support older browsers.

Root cause (required for bugfixes)

This bug was caused by the method not being supported on older browsers (MDN docs).

UI changes

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@maximo-macchi-cb maximo-macchi-cb self-assigned this Apr 1, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Apr 1, 2026

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 1, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

@maximo-macchi-cb maximo-macchi-cb merged commit db36a26 into master Apr 1, 2026
37 checks passed
@maximo-macchi-cb maximo-macchi-cb deleted the max/remove-array-at-method branch April 1, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants