Skip to content

feat: slack notifications#625

Merged
hcopp merged 6 commits intomasterfrom
hunter/slack-notifications
Apr 20, 2026
Merged

feat: slack notifications#625
hcopp merged 6 commits intomasterfrom
hunter/slack-notifications

Conversation

@hcopp
Copy link
Copy Markdown
Contributor

@hcopp hcopp commented Apr 17, 2026

What changed? Why?

This PR adds slack notifications for when PRs are ready for review and when NPM fails to publish.

I have disabled it for dry runs (previously had enabled for testing).

Testing

How has it been tested?

Was tested manually

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 17, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@hcopp hcopp self-assigned this Apr 17, 2026
@hcopp hcopp marked this pull request as ready for review April 17, 2026 21:12
@hcopp hcopp requested a review from sverg-cb April 17, 2026 22:28
Copy link
Copy Markdown
Contributor

@cb-ekuersch cb-ekuersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits around documentation

Comment thread .github/workflows/publish.yml
Comment thread .github/workflows/slack-pull-request.yml
Comment thread .github/workflows/slack-pull-request.yml
@hcopp hcopp merged commit 80224bf into master Apr 20, 2026
26 checks passed
@hcopp hcopp deleted the hunter/slack-notifications branch April 20, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants