Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
sverg-cb
previously approved these changes
Apr 20, 2026
hcopp
commented
Apr 20, 2026
| } else { | ||
| clipProgress.value = 0; | ||
| clipProgress.value = buildTransition(1, animate ? clipUpdateTransition : null); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We should only animate when we have a valid size.
hcopp
commented
Apr 20, 2026
Contributor
sverg-cb
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR fixes an issue with bar animations on mobile and also double checked to confirm that the issue wasn't present on web.
Root cause (required for bugfixes)
Our drawingArea was defined with
{ x: 0, y: 0, width: 0, height: 0 }for 1 render which was defined soif (!drawingArea) return;wasn't called and because of this we were animating the initial render. This was only noticeable in fast paced animations (see Slow Spring Both and Staggered Interrupts in ChartTransitions). But I think we could look at this further in other spots if customers mention it.UI changes
rapid_before.mov
rapid_after.mov
spring_before.mov
spring_after.mov
Testing
How has it been tested?
All the testing was manual, unfortunately skia doesn't support direct ui tests and this is solely a UI issue.
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false