Skip to content

feat: CDS-1694#661

Merged
cb-ekuersch merged 4 commits intomasterfrom
cds-1694
May 1, 2026
Merged

feat: CDS-1694#661
cb-ekuersch merged 4 commits intomasterfrom
cds-1694

Conversation

@cb-ekuersch
Copy link
Copy Markdown
Contributor

@cb-ekuersch cb-ekuersch commented May 1, 2026

What changed? Why?

https://linear.app/coinbase/issue/CDS-1694/pagefooter-add-a-legal-text-support
Screenshot 2026-05-01 at 10 07 20 AM

Adds a legalText prop to PageFooter to match with designs, updates connect mappings and docs.

Also bumped the code connect CLI as well as improved our connect writing skills.

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 1, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@linear
Copy link
Copy Markdown

linear Bot commented May 1, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

@cb-ekuersch cb-ekuersch merged commit f1c23e5 into master May 1, 2026
38 of 39 checks passed
@cb-ekuersch cb-ekuersch deleted the cds-1694 branch May 1, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants