Skip to content

fix: support BoxBaseProps in mobile ListCell#667

Merged
hcopp merged 3 commits into
masterfrom
hunter/cell-box-base-props
May 6, 2026
Merged

fix: support BoxBaseProps in mobile ListCell#667
hcopp merged 3 commits into
masterfrom
hunter/cell-box-base-props

Conversation

@hcopp
Copy link
Copy Markdown
Contributor

@hcopp hcopp commented May 6, 2026

What changed? Why?

This PR adds BoxBaseProps to CellBaseProps on mobile, matching web.

UI changes

iOS Default iOS Custom
Web Default Web Custom
image image

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 6, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@hcopp hcopp marked this pull request as ready for review May 6, 2026 17:08
@hcopp hcopp requested a review from adrienzheng-cb May 6, 2026 17:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

@hcopp hcopp merged commit 1ed0ba9 into master May 6, 2026
37 checks passed
@hcopp hcopp deleted the hunter/cell-box-base-props branch May 6, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants