fix: use 8px gap between Alert action buttons#690
Closed
nicoledbelcher wants to merge 2 commits into
Closed
Conversation
Align Alert's stacked action button spacing with the ButtonGroup spec.
Both web and mobile Alert components previously used gap={2} (16px)
between their preferred and dismiss actions; this updates them to
gap={1} (8px) for consistency with current design guidance.
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
Adds CHANGELOG entries for the Alert action-button gap fix and syncs common + mcp-server to 8.74.4 via yarn release. Co-authored-by: Cursor <cursoragent@cursor.com>
7 tasks
Contributor
|
ahh there seem to be some conflicts. Let me know if you need help resolving them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alertto usegap={1}(8px) instead ofgap={2}(16px) between stacked action buttons (preferred + dismiss), in both horizontal and vertical layouts.Linear: CDS-2052
Affected files
packages/web/src/overlays/Alert.tsxpackages/mobile/src/overlays/Alert.tsxThe docs site at https://cds.coinbase.com/components/overlay/Alert/ does not need any MDX changes; it renders the live
Alertcomponent, so it will reflect the 8px gap automatically after the next@coinbase/cds-web/@coinbase/cds-mobilerelease is published.Test plan
yarn nx run web:test --testPathPattern=overlays/__tests__/Alert.test.tsx— 12/12 passedyarn nx run mobile:test --testPathPattern=overlays/__tests__/Alert.test.tsx— 7/7 passedyarn nx run web:typecheck— passesyarn nx run mobile:typecheck— passesyarn nx format:writeon modified filesAlertBasic,AlertVerticalActions,AlertSingleAction) that horizontal and vertical action layouts now show 8px between buttons.