feat: factor container offset for sparkline axes#87
Merged
hcopp merged 2 commits intocharts/v3.3from Oct 8, 2025
Merged
Conversation
stacysun-cb
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR subtracts the container left offset for sparkline x axis label calculations.
Root cause (required for bugfixes)
Sparkline axis was not factoring in the offset of the container as a whole when getting the position of each marker label. As such, a chart with a large left offset would show less labels.
UI changes
Full Width Chart
Working as expected, before and after
Skinny Chart
Fixed with this PR
Testing
How has it been tested?
Testing instructions
Change management
type=routine
risk=low
impact=sev5
automerge=false