Skip to content

Fix typo in SyncStatus#75

Merged
shrimalmadhur merged 1 commit into
coinbase:masterfrom
matheusd:typo
Aug 24, 2021
Merged

Fix typo in SyncStatus#75
shrimalmadhur merged 1 commit into
coinbase:masterfrom
matheusd:typo

Conversation

@matheusd
Copy link
Copy Markdown
Contributor

@matheusd matheusd commented Feb 9, 2021

Found while reviewing the latest version.

@shrimalmadhur
Copy link
Copy Markdown
Contributor

Found while reviewing the latest version.

@matheusd do you mind rebasing this and pushing the branch. There was some circleci and build issue which we fixed. After that your PR should be ready to go. Thanks!

@matheusd
Copy link
Copy Markdown
Contributor Author

Rebased against latest master but still getting failures in the CI.

@shrimalmadhur
Copy link
Copy Markdown
Contributor

shrimalmadhur commented Aug 23, 2021

Rebased against latest master but still getting failures in the CI.

@matheusd I see what's going on here. you will also need to run make gen to make sure the api.json file includes your change. https://github.com/coinbase/rosetta-specifications#specification-development

@shrimalmadhur shrimalmadhur merged commit ffc01b4 into coinbase:master Aug 24, 2021
@matheusd matheusd deleted the typo branch August 25, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants