feat: WalletAdvanced docs#1819
Merged
Merged
Conversation
github-actions
Bot
added
documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abcrane123
reviewed
Jan 15, 2025
abcrane123
reviewed
Jan 15, 2025
| ## `WalletAdvancedContextType` | ||
|
|
||
| ```ts | ||
| export type WalletAdvancedContextType = { |
Contributor
There was a problem hiding this comment.
same with this one. does it need to be exposed?
Contributor
There was a problem hiding this comment.
I think I missed it in the other wallet advanced PR, but I don't think we should export WalletAdvancedContextType or include in external docs - it's an internal implementation detail that's unhelpful / confusing to users
Is there a use case you have in mind?
abcrane123
reviewed
Jan 15, 2025
cpcramer
reviewed
Jan 15, 2025
cpcramer
reviewed
Jan 15, 2025
Comment on lines
+219
to
+224
| <WalletAdvanced> | ||
| <WalletAdvancedWalletActions /> | ||
| <WalletAdvancedAddressDetails /> | ||
| <WalletAdvancedTransactionActions /> | ||
| <WalletAdvancedTokenHoldings /> | ||
| </WalletAdvanced> |
There was a problem hiding this comment.
Should we showcase some of the props in action?
cpcramer
reviewed
Jan 15, 2025
| Wallet modal offers users multiple wallet connection options. Explore these options | ||
| [here](/wallet/wallet#using-wallet-modal). | ||
|
|
||
| ## Example usage |
There was a problem hiding this comment.
Could also be good to showcase theming and link to customizing themes
Author
There was a problem hiding this comment.
i like that, esp for the QR codes, will add as a fast-follow
abcrane123
reviewed
Jan 15, 2025
0xAlec
reviewed
Jan 15, 2025
0xAlec
reviewed
Jan 15, 2025
fakepixels
previously approved these changes
Jan 15, 2025
cpcramer
previously approved these changes
Jan 15, 2025
cpcramer
approved these changes
Jan 15, 2025
fakepixels
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
WalletAdvanced, includingWalletAdvancedDefault,WalletIsland, and customization optionsNotes to reviewers
How has it been tested?