chore: Update MiniKit mini app manifest #2355

dgca · 2025-05-08T21:03:59Z

What changed? Why?

Updates manifest generation in create-onchain --mini to align with latest spec

Notes to reviewers

New projects created with npx create-onchain@latest --mini will get the new manifest fields.

Generating the manifest via npx create-onchain@latest --manifest will work for both new and old projects.

How has it been tested?

Manually
Unit tests

vercel · 2025-05-08T21:04:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
onchainkit-coverage	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2025 6:35pm
onchainkit-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2025 6:35pm
onchainkit-routes	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2025 6:35pm

cb-heimdall · 2025-05-08T21:04:05Z

✅ Heimdall Review Status

Requirement Status More Info

Reviews

✅ 2/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 0

Global minimum 0

Max 1

1

1 if commit is unverified 0

Sum 1

dgca · 2025-05-09T21:39:03Z

packages/create-onchain/tsconfig.json

-    "target": "ES2020",
-    "module": "ES2020",
+    "target": "ES2021",
+    "module": "ESNext",


Needed this to do string.replaceAll(x, y)

abcrane123

looks good!

xtbase

looks good but one question is regarding the images that are being included, i'm assuming these are farcaster required image endpoints?

xtbase · 2025-05-13T18:41:28Z

packages/create-onchain/templates/minikit-basic/app/.well-known/farcaster.json/route.ts

-    frame: {
-      version: process.env.NEXT_PUBLIC_VERSION,
+    frame: withValidProperties({
+      version: "1",


is it okay changing it to fixed value of 1 vs using the env var?

I figured this doesn't really make sense as an environment variable because the mini app spec requires that this value be "1". IMO, making it an env var implies that it can be changed. It also clashes with the fc:frame version, which must be "next".

xtbase · 2025-05-13T18:41:39Z

packages/create-onchain/templates/minikit-basic/app/layout.tsx

      "fc:frame": JSON.stringify({
-        version: process.env.NEXT_PUBLIC_VERSION,
-        imageUrl: process.env.NEXT_PUBLIC_IMAGE_URL,
+        version: "next",


same as above

dgca · 2025-05-13T19:34:29Z

looks good but one question is regarding the images that are being included, i'm assuming these are farcaster required image endpoints?

Not required, but figured we should include so devs can just swap em out and also use them for size reference :)

* Add .circleci/config.yml * chore: add context exports (coinbase#2261) * feat: Add batch ENS / Basename resolution with useAddresses hook and getAddresses utility (coinbase#2277) * chore: add provider exports back (coinbase#2278) * refactor: Replace Packemon with Vite (coinbase#2227) * fix: Don't clean out out dir when building in dev mode (coinbase#2279) * fix wallet modal (coinbase#2282) * fix: Separate deafult Wagmi and Query providers (coinbase#2280) * chore: show connect button when disconnected in Identity demo (coinbase#2285) * Fix: Flaky AppchainBridgeProvider network toggle test (coinbase#2288) * refactor: send display name (coinbase#2283) * chore: Refactor getNames utility to leverage batch processing with getAddresses (coinbase#2281) * chore: fix typos in documentation (coinbase#2286) * chore: Dynamically set version in version.ts (coinbase#2290) * fix: viem version (coinbase#2291) * fix: viem (coinbase#2293) * fix: viem (coinbase#2295) * chore: Add @farcaster/frame-sdk dependency to minikit templates (coinbase#2297) * chore: bump cli templates deps (coinbase#2296) * chore: remove smart wallet check from cli prompt (coinbase#2287) * fix: ready options (coinbase#2300) * fix: authenticate against user fid (coinbase#2299) * chore: version packages v 0.38.8 🌊 (coinbase#2276) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * fix: OnchainKit package.json publishConfig.access = public (coinbase#2306) * chore: add redirect for `getOnrampBuyUrl` (coinbase#2104) * fix: signature provider unmount reset (coinbase#2172) * fix: Updates playground to remove outdated imports (coinbase#2294) * chore(deps): bump next from 14.2.25 to 14.2.26 (coinbase#2215) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update `create-onchain` version (coinbase#2315) * fix: rpcUrl (coinbase#2319) * chore: update release workflows (coinbase#2314) * fix: fix root build command (coinbase#2320) * fix: fix build command in workflow (coinbase#2321) * fix: narrow filtering for release workflow (coinbase#2322) * chore: version packages v0.38.9 🌊 (coinbase#2323) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> * fix: support an insecure fallback for session id to allow for testing on http contexts (coinbase#2318) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: Make create-onchain library public (coinbase#2324) * chore: Don't ask to generate manifest during app creation in create-onchain (coinbase#2326) * fix: Basenames bidirectional validation (coinbase#2329) * chore: version packages v0.38.10 🌊 (coinbase#2330) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> * fix: getSocials (coinbase#2333) * docs: fix broken link (coinbase#2331) * feat: Make sign up button optional (coinbase#2332) * chore: Release changesets (coinbase#2342) * Chore: workflow improvement for vscode/cursor users (coinbase#2334) * chore: version packages 🚀 (coinbase#2343) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * chore: enable paymaster for wallet advanced Send (coinbase#2335) * fix: MiniKit frames connector (coinbase#2347) * chore: version packages 🚀 (coinbase#2348) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * fix: Update wagmi config if connectors change (coinbase#2350) * chore: version packages 🚀 (coinbase#2352) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * chore(deps-dev): bump vite from 6.2.3 to 6.2.7 (coinbase#2327) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Use signed commits for Changesets action (coinbase#2351) * chore: Update MiniKit mini app manifest (coinbase#2355) * chore: version packages 🚀 (coinbase#2362) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> Co-authored-by: Paul Cramer <paulccramer@gmail.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> Co-authored-by: Brendan from DeFi <brendan.forster@coinbase.com> Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com> Co-authored-by: Adam <alessey@gmail.com> Co-authored-by: Zach Blake <ztb@pm.me> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Schlabach <31226559+dschlabach@users.noreply.github.com> Co-authored-by: Teimur Gasanov <teymurgg321@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: xtbase <teaonbase@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: GarmashAlex <garmasholeksii@gmail.com>

dgca added 2 commits May 8, 2025 14:53

chore: Update mini app manifest fields

8acb062

Update tests and README

87b5474

vercel bot deployed to Preview – onchainkit-coverage May 8, 2025 21:06 View deployment

Update env var setting

8f0aa8e

vercel bot deployed to Preview – onchainkit-routes May 9, 2025 18:38 View deployment

vercel bot deployed to Preview – onchainkit-playground May 9, 2025 18:39 View deployment

vercel bot deployed to Preview – onchainkit-coverage May 9, 2025 18:41 View deployment

Update app version env var

df21fc3

vercel bot deployed to Preview – onchainkit-routes May 9, 2025 18:45 View deployment

vercel bot deployed to Preview – onchainkit-playground May 9, 2025 18:46 View deployment

vercel bot deployed to Preview – onchainkit-coverage May 9, 2025 18:48 View deployment

Verify env vars, add all photos to snake

ebe9754

vercel bot deployed to Preview – onchainkit-routes May 9, 2025 20:08 View deployment

vercel bot deployed to Preview – onchainkit-playground May 9, 2025 20:09 View deployment

vercel bot deployed to Preview – onchainkit-coverage May 9, 2025 20:12 View deployment

Hardcode version

7e6edc7

vercel bot deployed to Preview – onchainkit-routes May 9, 2025 21:20 View deployment

vercel bot deployed to Preview – onchainkit-playground May 9, 2025 21:21 View deployment

Hardcode version

41e743a

vercel bot deployed to Preview – onchainkit-routes May 9, 2025 21:22 View deployment

vercel bot deployed to Preview – onchainkit-playground May 9, 2025 21:23 View deployment

vercel bot deployed to Preview – onchainkit-coverage May 9, 2025 21:27 View deployment

dgca commented May 9, 2025

View reviewed changes

abcrane123 previously approved these changes May 12, 2025

View reviewed changes

Changeset

ee87dec

dgca dismissed abcrane123’s stale review via ee87dec May 13, 2025 18:32

vercel bot deployed to Preview – onchainkit-routes May 13, 2025 18:32 View deployment

vercel bot deployed to Preview – onchainkit-playground May 13, 2025 18:33 View deployment

vercel bot deployed to Preview – onchainkit-coverage May 13, 2025 18:35 View deployment

xtbase approved these changes May 13, 2025

View reviewed changes

abcrane123 approved these changes May 13, 2025

View reviewed changes

dgca merged commit 5656374 into main May 13, 2025
19 checks passed

dgca deleted the danc/minikit-manifest-update branch May 13, 2025 19:34

Dargon789 pushed a commit to Dargon789/onchainkit that referenced this pull request May 26, 2025

chore: Update MiniKit mini app manifest (coinbase#2355)

930c401

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Update MiniKit mini app manifest #2355

chore: Update MiniKit mini app manifest #2355

Uh oh!

dgca commented May 8, 2025 •

edited

Loading

Uh oh!

vercel bot commented May 8, 2025 •

edited

Loading

Uh oh!

cb-heimdall commented May 8, 2025 •

edited

Loading

Uh oh!

dgca May 9, 2025

Uh oh!

abcrane123 left a comment

Uh oh!

xtbase left a comment

Uh oh!

xtbase May 13, 2025

Uh oh!

dgca May 13, 2025

Uh oh!

xtbase May 13, 2025

Uh oh!

dgca commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

chore: Update MiniKit mini app manifest #2355

chore: Update MiniKit mini app manifest #2355

Uh oh!

Conversation

dgca commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cb-heimdall commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Heimdall Review Status

Uh oh!

dgca May 9, 2025

Choose a reason for hiding this comment

Uh oh!

abcrane123 left a comment

Choose a reason for hiding this comment

Uh oh!

xtbase left a comment

Choose a reason for hiding this comment

Uh oh!

xtbase May 13, 2025

Choose a reason for hiding this comment

Uh oh!

dgca May 13, 2025

Choose a reason for hiding this comment

Uh oh!

xtbase May 13, 2025

Choose a reason for hiding this comment

Uh oh!

dgca commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

dgca commented May 8, 2025 •

edited

Loading

vercel bot commented May 8, 2025 •

edited

Loading

cb-heimdall commented May 8, 2025 •

edited

Loading