Skip to content

Conversation

@jaffarkeikei
Copy link

What changed? Why?

formatAmount now validates input and returns empty string for invalid values instead of "NaN" or "∞".

Notes to reviewers

Without validation:

formatAmount('abc')       // Returns "NaN" ❌
formatAmount('Infinity')  // Returns "∞" ❌

With fix:

formatAmount('abc')       // Returns "" ✓
formatAmount('Infinity')  // Returns "" ✓

Uses Number.isFinite() to catch both NaN and Infinity.

How has it been tested?

Manual testing with edge cases:

  • Non-numeric strings: returns empty string
  • Infinity: returns empty string
  • Valid numbers: formatted correctly

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel
Copy link

vercel bot commented Jan 29, 2026

@jaffarkeikei is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants