Skip to content

Conversation

@ghbren
Copy link
Contributor

@ghbren ghbren commented Jun 29, 2021

By default, BundleAudit pulls advisory info from ruby-advisory-db.
This PR adds support for scanning against a local advisory DB. The config below will scan against the local DB in addition to ruby-advisory-db.

scanner_configs:
  BundleAudit:
    local_db: $local_db_dir

Copy link
Contributor

@joshuaostrom-cb joshuaostrom-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Do we foresee a case where we'd want to run only against the local advisory DB (and not dual run against the ruby-advisory-db too)? If so, I could see a use case for a local-db-only:true config or similar. But not need to be a blocker if it's a YAGNI.

@ghbren
Copy link
Contributor Author

ghbren commented Jul 19, 2021

PR looks good. Do we foresee a case where we'd want to run only against the local advisory DB (and not dual run against the ruby-advisory-db too)? If so, I could see a use case for a local-db-only:true config or similar. But not need to be a blocker if it's a YAGNI.

Good question. But I have not seen a case where we only want to run against the local DB.

@cb-heimdall cb-heimdall dismissed joshuaostrom-cb’s stale review July 19, 2021 17:45

Approved review 709769858 from joshua-ostrom is now dismissed due to new commit. Re-request for approval.

@ghbren ghbren merged commit 4339782 into master Jul 21, 2021
@ghbren ghbren deleted the bundle_audit_local branch July 21, 2021 18:31
@ghbren ghbren mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants