Adding Salus enforced bool #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "rules" => rules | ||
| "rules" => rules, | ||
| "properties" => { | ||
| "salusEnforced": @required || false |
Contributor
There was a problem hiding this comment.
IIRC the || false was to ensure we had proper support here for unsupported (scanners that don't yet have a sarif adapter present) scanners. If that's the case can you include one spec for that case? Beyond that looks great!
Contributor
Author
There was a problem hiding this comment.
Yep that's the case, actually I just remembered, the unsupported scanner case is already being tested in base_sarif_spec.rb around lines 12-20. I'd be happy to add another spec if this is insufficient!
joshuaostrom-cb
previously approved these changes
Jul 20, 2021
cb-heimdall
dismissed
joshuaostrom-cb’s stale review
Approved review 710656806 from joshua-ostrom is now dismissed due to new commit. Re-request for approval.
joshuaostrom-cb
previously approved these changes
Jul 21, 2021
cb-heimdall
dismissed
joshuaostrom-cb’s stale review
Approved review 712224772 from joshua-ostrom is now dismissed due to new commit. Re-request for approval.
joshuaostrom-cb
approved these changes
Jul 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adding Salus enforced bool under tool.driver.properties in SARIF in order to update Salus-bots display and cause less confusion surrounding active/enforced scanners
Notes to reviewers
How has it been tested?
Unit testing
Helpful Links
General troubleshooting and FAQ
Change management (definitions)
type=routine
risk=low
impact=sev5
Automerge
automerge=false