Salus verb header support in config yaml #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jeffrey778zhan merged 14 commits into master from jeffreyz/CycloneDX-format-support

Aug 13, 2021

Contributor

jeffrey778zhan commented Aug 5, 2021 •

edited

Loading

What's changed?

Added Salus support for CycloneDX-json format as well as new headers/environment_headers and verbs (put, post only for now, we can add as we need). Changed Docs to reflect that.
Refactored logic in report.rb specific to creating an HTTP request i.e the header and faraday to another class ReportRequest
Added in cyclonedx_options support in config yaml file. More details in docs.

How has it been tested?
Unit tests and tested locally with simple server that echoes back requests.

jeffrey778zhan added 5 commits

August 5, 2021 15:42


          add in verb header support with specs

5afc63e


          rubocop nit

e0054d3


          use header_env_var for secret values

d5925eb


          add cyclonedx and new verb/header to config docs

480d9b0


          add nil check for post config param

7bc1e89

jeffrey778zhan commented

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved

jeffrey778zhan commented

View reviewed changes

lib/salus/report.rb Show resolved Hide resolved


          Merge branch 'master' into jeffreyz/CycloneDX-format-support

a1fd2b6

jeffrey778zhan marked this pull request as ready for review

August 9, 2021 16:29

jeffrey778zhan requested review from ghbren, joshuaostrom-cb and saron-deb

August 9, 2021 16:29

jeffrey778zhan commented

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved

ghbren reviewed

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved


          add encoding for bom to base64

9f11d47

joshuaostrom-cb reviewed

View reviewed changes

docs/configuration.md Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

docs/configuration.md Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report.rb Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

spec/lib/salus/processor_spec.rb Outdated Show resolved Hide resolved

jeffrey778zhan added 4 commits

August 10, 2021 13:54


          use env var interpolation for cyclonedx, refactor report request logic

b40306c


          add in new cyclonedx option for cyclonedx_project_name

06903ec


          fix tests

eb4b7cb


          change spec to expect static method instead of instance method

bc322d1

jeffrey778zhan requested a review from joshuaostrom-cb

August 11, 2021 18:35

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report_request.rb Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report_request.rb Outdated Show resolved Hide resolved

joshuaostrom-cb reviewed

View reviewed changes

lib/salus/report_request.rb Show resolved Hide resolved

jeffrey778zhan added 2 commits

August 12, 2021 14:22


          add constants for xscanner and refactor sending verb

71752d8


          rubocop

15e71cf

joshuaostrom-cb previously approved these changes

View reviewed changes


          Merge branch 'master' into jeffreyz/CycloneDX-format-support

cb-heimdall dismissed joshuaostrom-cb’s stale review

August 12, 2021 22:25

Approved review 729095752 from joshua-ostrom is now dismissed due to new commit. Re-request for approval.

jeffrey778zhan requested a review from joshuaostrom-cb

August 12, 2021 23:11

ghbren self-requested a review

August 13, 2021 00:10

ghbren approved these changes

View reviewed changes

jeffrey778zhan merged commit fe65097 into master

jeffrey778zhan deleted the jeffreyz/CycloneDX-format-support branch

August 13, 2021 00:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet