Adding support for Python CycloneDx #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saron-deb
commented
Aug 9, 2021
ghbren
reviewed
Aug 9, 2021
| "type": "library", | ||
| "group": "", | ||
| "name": "amqp", | ||
| "version": "==2.2.2", |
Contributor
There was a problem hiding this comment.
Maybe remove == so that we have this?
"version": "2.2.2",What do you think, Josh?
Contributor
Author
There was a problem hiding this comment.
Yep I can remove == for pinned requirements. It's just for unpinned/semi-pinned requirements, if something like
>=3.2.1
is given for example, getting rid of >= might cause confusion as we wouldn't be able to tell that any newer version (3.2.1+) is also specified?
joshuaostrom-cb
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Python in CycloneDx implementation