Skip to content

CycloneDX Error handling at the language level #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeffrey778zhan merged 5 commits into from
Aug 23, 2021
Merged

CycloneDX Error handling at the language level #429

jeffrey778zhan merged 5 commits into from
Aug 23, 2021

Conversation

@jeffrey778zhan
Copy link
Contributor

@jeffrey778zhan jeffrey778zhan commented Aug 23, 2021 •
edited
Loading

What Changed?

  • Added error handling at the language level for cyclonedx reporting
  • Refactored cycloned spec version check

How was it tested?

  • Tested a build which threw an exception for one language dependency and ensured dependencies of other languages were still captured

jeffrey778zhan
jeffrey778zhan commented Aug 23, 2021
View reviewed changes
lib/cyclonedx/base.rb
"Incorrect Cyclone Version Specified: #{@config['spec_version']}." \
" Should be exactly 1.2 or 1.3"
end
component.delete(:properties) if @config['spec_version'] == "1.2"
Copy link
Contributor Author

@jeffrey778zhan jeffrey778zhan Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guaranteed valid spec version at this point

joshuaostrom-cb
joshuaostrom-cb approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@joshuaostrom-cb joshuaostrom-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffrey778zhan jeffrey778zhan merged commit a4ebbf5 into master Aug 23, 2021
@jeffrey778zhan jeffrey778zhan deleted the jeffreyz/error_handling_cyclonedx_languages branch August 23, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saron-deb saron-deb Awaiting requested review from saron-deb

@ghbren ghbren Awaiting requested review from ghbren

1 more reviewer

@joshuaostrom-cb joshuaostrom-cb joshuaostrom-cb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffrey778zhan @joshuaostrom-cb