-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Stellar scheme specification for x402 v2 exact #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Stellar scheme specification for x402 v2 exact #941
Conversation
🟡 Heimdall Review Status
|
|
@marcelosalloum is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks a lot for putting this together @marcelosalloum! Notified the core team to review |
|
@marcelosalloum it is my understanding that you are from the Stellar team, is this correct? If so, was this already internally reviewed? Otherwise, would be great to also get some feedback from the Stellar team on this proposal |
|
@phdargen: yep I'm from the Stellar team. We had this reviewed as an internal doc before and I'm also asking my team for another review here in the repo. Thanks. |
Great, thank you! |
|
From the perspective of Stellar blockchain features, this schema specification looks good to me. |
|
The schema with the latest changes looks good to me! Thanks you @marcelosalloum |
|
Hey @phdargen, @CarsonRoscoe: we at the Stellar team have completed our internal reviews, and we've incorporated it on the spec proposal. Plz let me know if you have any questions. I'm marking #711 as draft and will reopen it once the spec is fully synced and merged. |
…ndation 1. Remove `maxLedgerOffset` and calculate expiration ledger based on `maxTimeoutSeconds`. 2. Make it clear that facilitator's `/settle` should not assume prior validation and the flow doesn't need to go through `/validate` 3. Add an important check that ensures the simulation emits the expected transfer/balance events
34f7eee to
4a6ded3
Compare
Description
Adds formal specification documentation for the
exactpayment scheme on Stellar blockchain, addressing the request in #711.This spec follows the same structure as existing network-specific scheme documents (EVM, SVM, SUI) and defines how x402 v2 payments work on Stellar using its smart contracts platform. It includes an appendix with Stellar-specific knowledge.
TestsNo code affected
Checklist
I have formatted and linted my codeAll new and existing tests pass