fix: add navigation behaviour to TagsInput [MDS-1711]#300
Merged
robb91-dev merged 8 commits intomainfrom Apr 1, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: c09638e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
robb91-dev
changed the title
MarioGranada
suggested changes
Apr 1, 2025
ethenne
reviewed
Apr 1, 2025
MarioGranada
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add navigation behaviour MDS-1711
Expected behaviour:
When the user types something and clicks outside the input, the entered text should be converted into a tag.
The user should be able to navigate through existing tags using the keyboard arrow keys.
When a tag is selected, pressing the Delete key should remove it.
If user clicks on a tag, that should be highlighted
If there are existing tags and no characters have been typed, pressing backspace should highlight the last tag
Accessibility issues should be fixed