fix(edit): add --editor flag and validate editor before launching#7
Merged
Conversation
Add a `-e`/`--editor` CLI flag to override the editor used by the edit command. Editor resolution now prefers the flag, falls back to $EDITOR, and fails explicitly when neither is set (instead of silently defaulting to vim). The resolved editor is validated via `which` before launch to give a clear error on missing executables. Add unit tests for resolve_editor, try_generate_edit_diffs, and display helpers, and add tests for PrintableActivityLog row rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
-e/--editorCLI flag to override the editor used by the edit command.Editor resolution now prefers the flag, falls back to
$EDITOR, and fails explicitly when neither is set (instead of silently defaulting to vim).The resolved editor is validated via
whichbefore launch to give a clear error on missing executables.Add unit tests for
resolve_editor,try_generate_edit_diffs, and display helpers, and add tests forPrintableActivityLogrow rendering.