Skip to content

fix: avoid mojibake in Windows terminal status output#174

Closed
Bortlesboat wants to merge 1 commit into
colbymchenry:mainfrom
Bortlesboat:fix/windows-safe-cli-status-markers
Closed

fix: avoid mojibake in Windows terminal status output#174
Bortlesboat wants to merge 1 commit into
colbymchenry:mainfrom
Bortlesboat:fix/windows-safe-cli-status-markers

Conversation

@Bortlesboat
Copy link
Copy Markdown

Summary

  • replace unicode status glyphs with ASCII markers ([OK], [ERR], [INFO], [WARN]) in shared CLI helpers
  • replace em dash in verbose progress output with ASCII - for safer rendering across terminals
  • keep behavior unchanged except output formatting

Why

Issue #168 reports garbled output on Windows PowerShell. This keeps status text readable in non-UTF terminal paths and log collectors.

Validation

pm ci`n-
pm test (existing upstream failures in installer-target tests + Node OOM; unrelated to this formatting-only change)

@colbymchenry
Copy link
Copy Markdown
Owner

Thanks for the patch! Superseded by #178, which keeps the spirit of your fix (ASCII markers for status icons) but extends coverage to src/ui/shimmer-worker.ts — the worker thread is the actual source of the mojibake in #168's screenshot because it uses fs.writeSync(1, …) and bypasses Node's TTY-aware UTF-8→codepage conversion on Windows. It also adds a supportsUnicode() check so macOS/Linux terminals keep the Unicode rendering.

You're credited in the CHANGELOG entry that ships in 0.7.10. Closing this one in favour of the merged fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants