fix: avoid mojibake in Windows terminal status output#174
Closed
Bortlesboat wants to merge 1 commit into
Closed
Conversation
5 tasks
Owner
|
Thanks for the patch! Superseded by #178, which keeps the spirit of your fix (ASCII markers for status icons) but extends coverage to You're credited in the CHANGELOG entry that ships in 0.7.10. Closing this one in favour of the merged fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #168 reports garbled output on Windows PowerShell. This keeps status text readable in non-UTF terminal paths and log collectors.
Validation
pm ci`n-
pm test (existing upstream failures in installer-target tests + Node OOM; unrelated to this formatting-only change)