You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Validate config.languages against the canonical LANGUAGES list from src/types.ts
Remove the stale hard-coded language allowlist in src/config.ts
Add regression coverage for supported languages that were previously rejected
Why
validateConfig() only allowed a small older subset of languages. Supported languages such as php, tsx, vue, liquid, pascal, and scala could be rejected even though they are valid CodeGraph languages.
Test plan
npx vitest run __tests__/foundation.test.ts
npm run build
npx vitest run __tests__/foundation.test.ts __tests__/search-query-parser.test.ts __tests__/extraction.test.ts -t "supported languages|Configuration|parseQuery"
Note: npm test full suite was attempted on Windows/Node v24.14.1 but failed in unrelated installer/MCP temp cleanup tests and ended with a V8 OOM worker crash.
Thanks for this, @kietdev27 — and sorry for the timing. This was a legitimate fix when you opened it: validateConfig() did carry a stale, narrower language allowlist than the canonical LANGUAGES list, so configs naming php/tsx/vue/etc. could be wrongly rejected.
It's since been overtaken by #285 ("zero-config indexing driven by .gitignore"), merged May 21, which removed src/config.ts and validateConfig() entirely. CodeGraph no longer has a config file or a languages allowlist — indexing is now driven by .gitignore, so there's nothing left to validate against, and the file this PR patches no longer exists on main.
Closing as obsolete — this reflects the refactor, not the quality of the change. The regression test was a nice touch; hope you'll send more PRs. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.languagesagainst the canonicalLANGUAGESlist fromsrc/types.tssrc/config.tsWhy
validateConfig()only allowed a small older subset of languages. Supported languages such asphp,tsx,vue,liquid,pascal, andscalacould be rejected even though they are valid CodeGraph languages.Test plan
npx vitest run __tests__/foundation.test.tsnpm run buildnpx vitest run __tests__/foundation.test.ts __tests__/search-query-parser.test.ts __tests__/extraction.test.ts -t "supported languages|Configuration|parseQuery"Note:
npm testfull suite was attempted on Windows/Node v24.14.1 but failed in unrelated installer/MCP temp cleanup tests and ended with a V8 OOM worker crash.