fix(extraction): extract type refs from TS interface property and method signatures#432
Merged
Merged
Conversation
…type annotations Types that appear only in interface property signatures (e.g. `value?: Partial<IPage>`) were not producing UnresolvedReferences, so the resolver never built `references` edges for them. Impact analysis consequently missed files that import-type only these interface-property types. Add a `property_signature` branch in `visitNode`: when inside a class-like node (includes interfaces) and the language supports type annotations, call `extractTypeAnnotations` with the parent (interface) node ID as the edge source. No property node is created — only unresolved references. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
method_signature inside interfaces (e.g. `foo(arg: T): R`) had the same root cause as the property_signature case fixed here — interface-body type annotations were dropped because the walker matched neither propertyTypes nor fieldTypes, so extractTypeRefsFromSubtree was never called for those members. Extend the dispatch to both node types and add a matching test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
colbymchenry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…type annotations
Types that appear only in interface property signatures (e.g.
value?: Partial<IPage>) were not producing UnresolvedReferences, so the resolver never builtreferencesedges for them. Impact analysis consequently missed files that import-type only these interface-property types.Add a
property_signaturebranch invisitNode: when inside a class-like node (includes interfaces) and the language supports type annotations, callextractTypeAnnotationswith the parent (interface) node ID as the edge source. No property node is created — only unresolved references.